[libcxx-commits] [PATCH] D145492: [libcxxabi][Demangle] Don't drop ctor/dtor name for abi-tagged structures

Michael Buch via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 9 08:13:40 PST 2023


Michael137 marked an inline comment as done.
Michael137 added inline comments.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:35-41
+  static_assert(std::is_pod<T>::value,
+                "T is required to be a plain old data type");
 
   T *First = nullptr;
   T *Last = nullptr;
   T *Cap = nullptr;
+  T Inline[N] = {0};
----------------
jhenderson wrote:
> Are these changes unrelated and simply because the two haven't been synced properly? If so, I'd do an NFC patch before this one to sync up the changes first.
Makes sense, done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145492/new/

https://reviews.llvm.org/D145492



More information about the libcxx-commits mailing list