[libcxx-commits] [PATCH] D145492: [libcxxabi][Demangle] Don't drop ctor/dtor name for abi-tagged structures

[James Henderson via Phabricator via libcxx-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Approving to clear my objection, but probably this could do with a pair of eyes more familiar with ABI tagging (or at least the mangling parts in relation to it).



================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:35-41
+  static_assert(std::is_pod<T>::value,
+                "T is required to be a plain old data type");
 
   T *First = nullptr;
   T *Last = nullptr;
   T *Cap = nullptr;
+  T Inline[N] = {0};
----------------
Are these changes unrelated and simply because the two haven't been synced properly? If so, I'd do an NFC patch before this one to sync up the changes first.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145492/new/

https://reviews.llvm.org/D145492