[libcxx-commits] [PATCH] D145186: [libc++] Temporarily not use compiler intrinsics for some type traits in Objective-C++ mode.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const marked 2 inline comments as done.
var-const added inline comments.


================
Comment at: libcxx/include/__config:1262
 
+// TODO(varconst): currently, there are bugs in Clang's intrinsics when handling Objective-C++ `id`, so don't use
+// compiler intrinsics in the Objective-C++ mode.
----------------
philnik wrote:
> FWIW I'd just drop the name from TODOs. If you want to know who wrote it you can just look at the git blame, so I don't really see an upside. They will just get out of date as people stop working on libc++. (We still have a few `TODO(EricWF)` in the code base and I have the feeling he won't resolve them.)
Personally, I find it useful. "TODO(name)" just means "'name' is the best person to ask about this issue", not "'name' is the person who will necessarily fix this issue". It's true that you can find it via blame, but a) it saves a context switch; and b) it's robust to copy-pasting, moving code between files, etc., all at essentially no cost. I find `TODO(EricWF)` useful regardless of whether Eric will work on those issues or not.


================
Comment at: libcxx/test/std/utilities/meta/meta.trans/objc_support.pass.mm:100-102
+int main(int, char**) {
+  return 0;
+}
----------------
philnik wrote:
> Maybe make this a `.compile.pass.mm` instead? Or do we not have that?
It doesn't work -- the linker complains about missing `_main`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145186/new/

https://reviews.llvm.org/D145186