[libcxx-commits] [PATCH] D145186: [libc++] Temporarily not use compiler intrinsics for some type traits in Objective-C++ mode.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__config:1262
 
+// TODO(varconst): currently, there are bugs in Clang's intrinsics when handling Objective-C++ `id`, so don't use
+// compiler intrinsics in the Objective-C++ mode.
----------------
FWIW I'd just drop the name from TODOs. If you want to know who wrote it you can just look at the git blame, so I don't really see an upside. They will just get out of date as people stop working on libc++. (We still have a few `TODO(EricWF)` in the code base and I have the feeling he won't resolve them.)


================
Comment at: libcxx/test/std/utilities/meta/meta.trans/objc_support.pass.mm:100-102
+int main(int, char**) {
+  return 0;
+}
----------------
Maybe make this a `.compile.pass.mm` instead? Or do we not have that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145186/new/

https://reviews.llvm.org/D145186