[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added inline comments.


================
Comment at: libcxx/utils/libcxx/test/params.py:116
+              AddCompileFlag('-DTEST_MODULES'),
+              AddCompileFlag(lambda cfg: '-fprebuilt-module-path=' + os.path.join(cfg.test_exec_root, '__config_module__/CMakeFiles/std.dir')),
+              AddLinkFlag(lambda cfg: os.path.join(cfg.test_exec_root, '__config_module__/libstd.a')),
----------------
Do we still need to pass `-fprebuilt-module-path=` now? From my understanding, cmake should manage the dependencies between modules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994