[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added inline comments.


================
Comment at: libcxx/docs/Modules.rst:42
+   not handle that case properly.
+ * There is no `P1689 style output <https://wg21.link/P1689>`_ yet.
+ * The experimental library (read <format>) does not work as expected
----------------
P1689 format is supported in clang-scan-deps. What's the reason we can't make it now?


================
Comment at: libcxx/docs/Modules.rst:43
+ * There is no `P1689 style output <https://wg21.link/P1689>`_ yet.
+ * The experimental library (read <format>) does not work as expected
+
----------------
aaronmondal wrote:
> 
I doesn't get this after I read `<format>`. What happened and what is expected?


================
Comment at: libcxx/stdmodules/CMakeLists.txt:12-21
+set(_all_modules "${LIBCXX_GENERATED_MODULE_DIR}/CMakeLists.txt")
+foreach(f ${LIBCXX_MODULE_SOURCES})
+  set(src "${CMAKE_CURRENT_SOURCE_DIR}/${f}")
+  set(dst "${LIBCXX_GENERATED_MODULE_DIR}/${f}")
+  add_custom_command(OUTPUT ${dst}
+    DEPENDS ${src}
+    COMMAND ${CMAKE_COMMAND} -E copy_if_different ${src} ${dst}
----------------
What's the intention of this code? From my understanding, we don't need to copy the .pcm files when cmake can handle them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994