[libcxx-commits] [PATCH] D153216: [libc++][Modules] Add missing includes to public headers

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D153216#4465367 <https://reviews.llvm.org/D153216#4465367>, @iana wrote:

> In D153216#4464361 <https://reviews.llvm.org/D153216#4464361>, @philnik wrote:
>
>> I don't think we actually want all of these headers to be included in the top-level header. Looking at the changes, all of these are implementation-detail headers, which don't contain any public API, so there is no need for them to be included.
>
> I think we do need them though. Previously importing e.g. `std.type_traits` would give you all of the detail headers. Once those are put in their own top level modules, they only get included if the public header includes them.

I don't see the problem. Users shouldn't ever refer to the stuff defined in these headers. If they do and splitting up the module breaks them, that's their problem, not ours.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153216/new/

https://reviews.llvm.org/D153216