[libcxx-commits] [PATCH] D153216: [libc++][Modules] Add missing includes to public headers

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 30 13:59:02 PDT 2023


iana added a comment.

In D153216#4464361 <https://reviews.llvm.org/D153216#4464361>, @philnik wrote:

> I don't think we actually want all of these headers to be included in the top-level header. Looking at the changes, all of these are implementation-detail headers, which don't contain any public API, so there is no need for them to be included.

We do need them though. Previously importing e.g. `std.type_traits` would give you all of the detail headers. Once those are put in their own top level modules, they only get included if the public header includes them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153216/new/

https://reviews.llvm.org/D153216



More information about the libcxx-commits mailing list