[libcxx-commits] [PATCH] D153980: [libc++][NFC] Move all the remaining .fail.cpp tests to .verify.cpp

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp:27
+// this builtin has different diagnostic messages than the fallback implementation.
+#if TEST_HAS_BUILTIN(__make_integer_seq)
+MakeSeqT i; // expected-error@*:* {{integer sequences must have non-negative sequence length}}
----------------
Mordante wrote:
> Why is it safe to remove the `!defined(_LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE)` part?
We used to only define it from the other sibling test, and then we'd `#include` the sources for this test. Now both tests are "standalone", i.e. they don't include each other so this test (which doesn't test the fallback) doesn't need to check for `_LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153980/new/

https://reviews.llvm.org/D153980