[libcxx-commits] [PATCH] D153980: [libc++][NFC] Move all the remaining .fail.cpp tests to .verify.cpp

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 28 08:17:40 PDT 2023


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

I only checked the called out tests. LGTM but I have a question.



================
Comment at: libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp:27
+// this builtin has different diagnostic messages than the fallback implementation.
+#if TEST_HAS_BUILTIN(__make_integer_seq)
+MakeSeqT i; // expected-error@*:* {{integer sequences must have non-negative sequence length}}
----------------
Why is it safe to remove the `!defined(_LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE)` part?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153980/new/

https://reviews.llvm.org/D153980



More information about the libcxx-commits mailing list