[libcxx-commits] [PATCH] D153977: [libc++][NFC] Add missing includes

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 2 inline comments as done.
ldionne added a comment.

In D153977#4456439 <https://reviews.llvm.org/D153977#4456439>, @Mordante wrote:

> Can you update the commit message by specifying which modules, I assume the clang ones, but the changes to `libcxx/test/std/utilities/format/types.compile.pass.cpp` suggest the `std` module.
>
> LGTM when the CI passes.

This was for Clang modules. I updated the commit message!



================
Comment at: libcxx/include/regex:800
 #include <__memory_resource/polymorphic_allocator.h>
+#include <__memory/shared_ptr.h>
 #include <__type_traits/is_swappable.h>
----------------
Mordante wrote:
> According the the CI at least this header is not in alphabetic order.
Thanks -- apparently VS Code disagrees with every other tool about what it means to be sorted.


================
Comment at: libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp:23-26
 #include <cassert>
+#include <filesystem>
+#include <fstream>
+#include <type_traits>
----------------
Mordante wrote:
> This is now in alphabetic order, in `.clang-format` we explicitly disable that for the tests. Any objections when I make a patch to remove that from that file. Then new tests are automatically formatted with headers sorted.
I don't think I'd have an objection, however I think you might hit some actual blockers while trying to do that? We probably have tests where the order of includes is important?

In that case I guess we could always use `// clang-format on/off` around the `#include`s.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153977/new/

https://reviews.llvm.org/D153977