[libcxx-commits] [PATCH] D153977: [libc++][NFC] Add missing includes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Can you update the commit message by specifying which modules, I assume the clang ones, but the changes to `libcxx/test/std/utilities/format/types.compile.pass.cpp` suggest the `std` module.

LGTM when the CI passes.



================
Comment at: libcxx/include/regex:800
 #include <__memory_resource/polymorphic_allocator.h>
+#include <__memory/shared_ptr.h>
 #include <__type_traits/is_swappable.h>
----------------
According the the CI at least this header is not in alphabetic order.


================
Comment at: libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp:23-26
 #include <cassert>
+#include <filesystem>
+#include <fstream>
+#include <type_traits>
----------------
This is now in alphabetic order, in `.clang-format` we explicitly disable that for the tests. Any objections when I make a patch to remove that from that file. Then new tests are automatically formatted with headers sorted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153977/new/

https://reviews.llvm.org/D153977