[libcxx-commits] [PATCH] D152382: [libc++] Expand the contents of LIBCXX_ENABLE_FILESYSTEM

Wed Jun 21 10:42:27 PDT 2023

ldionne marked 2 inline comments as done.
ldionne added inline comments.

================
Comment at: libcxx/include/__filesystem/directory_options.h:24

-_LIBCPP_AVAILABILITY_FILESYSTEM_LIBRARY_PUSH
-
----------------
Mordante wrote:
> Why can this be removed here and not in other places?
It's removed here because it does not fundamentally depend on anything in the dylib. Originally, I had marked everything in `<filesystem>` with availability macros using this `PUSH` macro. When `<filesystem>` was split out, the `PUSH` was copied to all the sub-headers, even though some parts of `<filesystem>` did not technically require it because they don't depend on anything in the dylib.

================
Comment at: libcxx/include/fstream:199
-#   include <filesystem>
-#endif
-
----------------
Mordante wrote:
> Did you see the comments in D152168 and the patch D153327?
I did not until now, but thanks for the heads up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152382/new/

https://reviews.llvm.org/D152382