[libcxx-commits] [PATCH] D152382: [libc++] Expand the contents of LIBCXX_ENABLE_FILESYSTEM

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this! In general LGTM, but a I have some questions.



================
Comment at: libcxx/include/__filesystem/copy_options.h:22
 
 _LIBCPP_BEGIN_NAMESPACE_FILESYSTEM
 
----------------
I think it makes sense to mention this in the release notes.


================
Comment at: libcxx/include/__filesystem/directory_options.h:24
 
-_LIBCPP_AVAILABILITY_FILESYSTEM_LIBRARY_PUSH
-
----------------
Why can this be removed here and not in other places?


================
Comment at: libcxx/include/fstream:199
-#   include <filesystem>
-#endif
-
----------------
Did you see the comments in D152168 and the patch D153327?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152382/new/

https://reviews.llvm.org/D152382