[libcxx-commits] [PATCH] D152737: [libc++][NFC] Reformat features.py

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added a comment.

In D152737#4414916 <https://reviews.llvm.org/D152737#4414916>, @Mordante wrote:

> No objection, but can you provide feedback regarding this issue on Discourse. I expect somebody will suggest enforcing Python formatting on commits; actually quite surprised that wasn't done in this project.
>
> I consider most changes by black not a real improvement.

Will do. Almost all of the changes I've seen so far have made code much less readable than it used to be. I missed the original discussion but if I had seen it and the result of the reformatting patch, I would have been an over-my-dead-body objection.

I'm in favour of automated formatting in the general case -- we didn't have clang-format and we do now. But when automated formatting makes the code really hard to read for arbitrary restrictions like 89 column width, then I'm not on board anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152737/new/

https://reviews.llvm.org/D152737