[libcxx-commits] [PATCH] D152737: [libc++][NFC] Reformat features.py

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

No objection, but can you provide feedback regarding this issue on Discourse. I expect somebody will suggest enforcing Python formatting on commits; actually quite surprised that wasn't done in this project.

I consider most changes by black not a real improvement.



================
Comment at: libcxx/utils/libcxx/test/features.py:26
         # If we didn't build the libcxx-tidy plugin via CMake, we can't run the clang-tidy tests.
-        if (
-            runScriptExitCode(
-                cfg, ["stat %{test-tools}/clang_tidy_checks/libcxx-tidy.plugin"]
-            )
-            != 0
-        ):
+        if runScriptExitCode(cfg, ["stat %{test-tools}/clang_tidy_checks/libcxx-tidy.plugin"])!= 0:
             return None
----------------



================
Comment at: libcxx/utils/libcxx/test/features.py:236
     Feature(
-        name=lambda cfg: "apple-clang-{__clang_major__}.{__clang_minor__}".format(
-            **compilerMacros(cfg)
-        ),
+        name=lambda cfg: "apple-clang-{__clang_major__}.{__clang_minor__}".format(**compilerMacros(cfg)),
         when=_isAppleClang,
----------------
FYI I don't feel these changes by black are bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152737/new/

https://reviews.llvm.org/D152737