[libcxx-commits] [PATCH] D152611: [libc++][spaceship] P1612R2: Removed `operator!=` from `bitset`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo some nits.



================
Comment at: libcxx/include/bitset:82
     bool operator==(const bitset& rhs) const noexcept; // constexpr since C++23
-    bool operator!=(const bitset& rhs) const noexcept; // constexpr since C++23
+    bool operator!=(const bitset& rhs) const noexcept; // constexpr since C++23, removed in C++20
     bool test(size_t pos) const;                       // constexpr since C++23
----------------
It's a bit weird to become constexpr when it's removed. Please remove the constexpr here.


================
Comment at: libcxx/include/bitset:765
+#if _LIBCPP_STD_VER <= 17
     _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23
     bool operator!=(const bitset& __rhs) const _NOEXCEPT;
----------------
H-G-Hristov wrote:
> `constexpr` since C++23 but removed in C++20 - Should I remove the macro?
Yes please.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152611/new/

https://reviews.llvm.org/D152611