[libcxx-commits] [PATCH] D152611: [libc++][spaceship] P1612R2: Removed `operator!=` from `bitset`

[Hristo Hristov via Phabricator via libcxx-commits]

H-G-Hristov added a comment.

In D152611#4411167 <https://reviews.llvm.org/D152611#4411167>, @Mordante wrote:

> In general LGTM, but I would like to land D152297 <https://reviews.llvm.org/D152297> first and directly update the status page.

Thank you for the review!



================
Comment at: libcxx/include/bitset:765
+#if _LIBCPP_STD_VER <= 17
     _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23
     bool operator!=(const bitset& __rhs) const _NOEXCEPT;
----------------
`constexpr` since C++23 but removed in C++20 - Should I remove the macro?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152611/new/

https://reviews.llvm.org/D152611