[libcxx-commits] [PATCH] D152612: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM after applying your own suggestion.



================
Comment at: libcxx/include/__memory/allocator.h:268
 template <class _Tp, class _Up>
 inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX20
 bool operator!=(const allocator<_Tp>&, const allocator<_Up>&) _NOEXCEPT {return false;}
----------------
H-G-Hristov wrote:
> `constexpr` since C++20, but removed in C++20. Should I remove the macro?
Good point, yes please do. We're done the same for the relational operator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152612/new/

https://reviews.llvm.org/D152612