[libcxx-commits] [PATCH] D152612: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`

Sat Jun 10 12:52:24 PDT 2023

H-G-Hristov added a comment.

In D152612#4411173 <https://reviews.llvm.org/D152612#4411173>, @Mordante wrote:

> In general LGTM, but I would like to land D152297 <https://reviews.llvm.org/D152297> first and directly update the status page.

Thank you for the review!

================
Comment at: libcxx/include/__memory/allocator.h:268
 template <class _Tp, class _Up>
 inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX20
 bool operator!=(const allocator<_Tp>&, const allocator<_Up>&) _NOEXCEPT {return false;}
----------------
`constexpr` since C++20, but removed in C++20. Should I remove the macro?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152612/new/

https://reviews.llvm.org/D152612