[libcxx-commits] [PATCH] D152378: [libc++][filesystem] Use _LIBCPP_HIDE_FROM_ABI in common headers

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D152378#4403678 <https://reviews.llvm.org/D152378#4403678>, @ldionne wrote:

> In D152378#4403648 <https://reviews.llvm.org/D152378#4403648>, @philnik wrote:
>
>> I understand that, but why not simply remove the anonymous namespace? What's the point of additionally adding `_LIBCPP_HIDE_FROM_ABI`?
>
> I guess we build the dylib with `-fvisibility=hidden`, so we don't need it technically. That was the original purpose. We could also argue that it's more consistent with the rest of the code, but I agree it's technically not needed.
>
> So I can either keep it for consistency, or just remove the `namespace { }` bit. Thoughts?

Most of the stuff in `src/` is written very similar to the headers, but IMO we should strive to make that stuff more maintainable. i.e. avoid anything that isn't required, like _Uglification, adding `_LIBCPP_HIDE_FROM_ABI` everywhere etc. I'm pretty sure everybody would love to remove that shit in the headers if it weren't necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152378/new/

https://reviews.llvm.org/D152378