[libcxx-commits] [PATCH] D152378: [libc++][filesystem] Use _LIBCPP_HIDE_FROM_ABI in common headers

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D152378#4403648 <https://reviews.llvm.org/D152378#4403648>, @philnik wrote:

> I understand that, but why not simply remove the anonymous namespace? What's the point of additionally adding `_LIBCPP_HIDE_FROM_ABI`?

I guess we build the dylib with `-fvisibility=hidden`, so we don't need it technically. That was the original purpose. We could also argue that it's more consistent with the rest of the code, but I agree it's technically not needed.

So I can either keep it for consistency, or just remove the `namespace { }` bit. Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152378/new/

https://reviews.llvm.org/D152378