[libcxx-commits] [PATCH] D151900: [libc++][NFC] Create a new folder for config-related headers.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/utils/generate_iwyu_mapping.py:39-40
     for i in detail_directories:
+        if i == "__config_dir":
+            continue
         public_header = temporary_mappings.get(i, i.lstrip("_"))
----------------
I wouldn't special case for `__config_dir` here.

The `libcxx.imp` file we generate right now is already incorrect in a few instances (for example we generate a line with `{ include: [ "@<__debug_utils/.*>", "private", "<debug_utils>", "public" ] },`) -- let's figure out how to handle it correctly for all our internal directories at once, not here.

We probably want to do something like this:

```
internal_directories = ['__config_dir', '__debug_utils', etc...]
for i in detail_directories:
  if i in internal_direcotries:
    continue
  ...
```

Or if you want, I guess you could actually do this in this patch and handle the following directories: `__debug_utils`, `__fwd`, `__pstl`, `__support`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151900/new/

https://reviews.llvm.org/D151900