[libcxx-commits] [PATCH] D151900: [libc++][NFC] Create a new folder for config-related headers.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__config_dir/debug.h:10
 
-#ifndef _LIBCPP___DEBUG
-#define _LIBCPP___DEBUG
+#ifndef _LIBCPP___CONFIG_DIR_DEBUG_H
+#define _LIBCPP___CONFIG_DIR_DEBUG_H
----------------
I think I would avoid touching this one since you can't include if from` __config`. Also per the RFC this is mostly going to go away.


================
Comment at: libcxx/include/module.modulemap.in:1811-1813
+  module __config_dir {
+    module availability { private header "__config_dir/availability.h"}
+  }
----------------
I think removing this should get rid of your circular dependency issue with modules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151900/new/

https://reviews.llvm.org/D151900