[libcxx-commits] [PATCH] D156585: [libc++][print] Make `<print>` tests require file system support.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I'm not against this patch, but I would like to investigate a bit further. When `FILE` is not available we will run into issues building the dylib. `src/print.cpp` includes `<print>` which has `FILE` in its interface. This works now because we build the dylib with C++20, but I expect it will fail when we switch to C++23. I have another patch for `print(ostream&...)` this patch  uses `FILE` in the dylib, so that is another potential issue before we switch to C++23. Can you test whether changing building the dylib with C++23 works on the platform in question?

I wonder whether `no-filesystem` is intended to mean no `cstdio`. If this patch is not urgent I would like to discuss it when Louis is back. If it's urgent we can finish the patch and discuss afterwards.



================
Comment at: libcxx/test/std/input.output/iostream.format/print.fun/lit.local.cfg:1
+if "no-filesystem" in config.available_features:
+    config.unsupported = True
----------------
Why do we need this? AFAIK we normally don't do this. Typically we disable all tests manually.


================
Comment at: libcxx/utils/libcxx/test/header_information.py:48
     "ostream": "// UNSUPPORTED: no-localization",
-    "print": "// UNSUPPORTED: availability-fp_to_chars-missing", # TODO PRINT investigate
+    "print": "// UNSUPPORTED: no-filesystem, c++03, c++11, c++14, c++17, c++20, availability-fp_to_chars-missing", # TODO PRINT investigate
     "regex": "// UNSUPPORTED: no-localization",
----------------
var-const wrote:
> Language modes are a drive-by fix.
Thanks good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156585/new/

https://reviews.llvm.org/D156585