[libcxx-commits] [PATCH] D156585: [libc++][print] Make `<print>` tests require file system support.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added a comment.

In D156585#4544020 <https://reviews.llvm.org/D156585#4544020>, @philnik wrote:

> I would really like it if we could add headers that make these kinds of things break. We should really look into using LLVM libc with the corresponding parts removed to improve the situation here. That being said, I think this patch is OK as-is. Leaving final approval to @Mordante, since he is the author of these utilities.

Yep, I was thinking of the same while working on this patch (e.g. the `no-filesystem` test should do something to make sure including a header that touches the file system would fail to compile).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156585/new/

https://reviews.llvm.org/D156585