[libcxx-commits] [PATCH] D154997: [libc++][hardening] Deprecate `_LIBCPP_ENABLE_ASSERTIONS`.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added a comment.

In D154997#4537400 <https://reviews.llvm.org/D154997#4537400>, @dblaikie wrote:

> Awesome - thanks for the fix!
>
> (anyone have any idea why this issue wasn't discovered sooner? are other libc++ developers doing something different from what I did? @ldionne?)

Louis is on vacation, but to echo what Nikolas said, libc++ developers normally don't build `llvm` or `clang`, just `libc++` and a few closely related targets. Not sure why other people building LLVM haven't encountered this, but perhaps they either don't build libc++ and/or don't use `-Werror`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154997/new/

https://reviews.llvm.org/D154997