[libcxx-commits] [PATCH] D154997: [libc++][hardening] Deprecate `_LIBCPP_ENABLE_ASSERTIONS`.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D154997#4537400 <https://reviews.llvm.org/D154997#4537400>, @dblaikie wrote:

> In D154997#4537052 <https://reviews.llvm.org/D154997#4537052>, @var-const wrote:
>
>> Ok, I verified locally that the fix in https://reviews.llvm.org/D156377 makes the build command succeed. I'll land the fix once the CI is green and ask for a cherry-pick for the LLVM 17 release.
>
> Awesome - thanks for the fix!
>
> (anyone have any idea why this issue wasn't discovered sooner? are other libc++ developers doing something different from what I did? @ldionne?)

Most libc++ developers (maybe even all right now) don't compile their own toolchain, especially not with assertions enabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154997/new/

https://reviews.llvm.org/D154997