[libcxx-commits] [PATCH] D154367: [libc++] mdspan - implement mdspan class

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added inline comments.


================
Comment at: libcxx/include/__mdspan/extents.h:210
   _LIBCPP_HIDE_FROM_ABI constexpr _TDynamic operator[](size_t __i) const {
     _LIBCPP_ASSERT_VALID_ELEMENT_ACCESS(__i < __size_, "extents access: index must be less than rank");
     return __value(__i);
----------------
Can you please double-check if this assertion is tested?


================
Comment at: libcxx/test/std/containers/views/mdspan/layout_right/assert.conversion.pass.cpp:1
 //===----------------------------------------------------------------------===//
 //
----------------
Nit: I think tests that check assertions usually are under `libcxx/test/libcxx`, not `libcxx/test/std` since they test libc++-specific behavior. This can be done in a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154367/new/

https://reviews.llvm.org/D154367