[libcxx-commits] [PATCH] D154367: [libc++] mdspan - implement mdspan class

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 21 14:32:50 PDT 2023


ldionne added a subscriber: var-const.
ldionne added inline comments.


================
Comment at: libcxx/include/__mdspan/extents.h:177
       else
-        _LIBCPP_ASSERT_UNCATEGORIZED(__values[__i] == static_cast<_TDynamic>(__static_val),
-                                     "extents construction: mismatch of provided arguments with static extents.");
+        _LIBCPP_ASSERT(__values[__i] == static_cast<_TDynamic>(__static_val),
+                       "extents construction: mismatch of provided arguments with static extents.");
----------------
I would keep this `_LIBCPP_ASSERT_UNCATEGORIZED` and then @var-const can categorize them appropriately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154367/new/

https://reviews.llvm.org/D154367



More information about the libcxx-commits mailing list