[libcxx-commits] [PATCH] D155760: [libcxx] Fix "copy_move.pass" test

Haowei Wu via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 20 00:18:38 PDT 2023


haowei added a comment.

In D155760#4517369 <https://reviews.llvm.org/D155760#4517369>, @mstorsjo wrote:

> In D155760#4516691 <https://reviews.llvm.org/D155760#4516691>, @ldionne wrote:
>
>> LGTM if CI is green.
>
> Just FWIW, it seems like the premerge CI never ran for this change. As long as all is well and it didn't trip anything up, this was fine, but ideally we should have fixed (setting the "repository" field to "rG <https://reviews.llvm.org/source/llvm-github/>" in the phabricator upload form, which gets set automatically when posting with arcanist) that and made sure the CI actually ran, before pushing it. It looks like the later scheduled runs on main are fine though.

I locally test it before I submit the change.

I noticed that the premerge bot unexpected timed out when checking out this change and I don't know how to kick it start again. So I just landed it and monitor the post submit bots.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155760/new/

https://reviews.llvm.org/D155760



More information about the libcxx-commits mailing list