[libcxx-commits] [PATCH] D155760: [libcxx] Fix "copy_move.pass" test

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 19 23:53:43 PDT 2023


mstorsjo added a comment.

In D155760#4516691 <https://reviews.llvm.org/D155760#4516691>, @ldionne wrote:

> LGTM if CI is green.

Just FWIW, it seems like the CI never ran for this change. As long as all is well and it didn't trip anything up, this was fine, but ideally we should have fixed (setting the "repository" field to "rG <https://reviews.llvm.org/source/llvm-github/>" in the phabricator upload form, which gets set automatically when posting with arcanist) that and made sure the CI actually ran, before pushing it. It looks like the later scheduled runs on main are fine though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155760/new/

https://reviews.llvm.org/D155760



More information about the libcxx-commits mailing list