[libcxx-commits] [PATCH] D155760: [libcxx] Fix "copy_move.pass" test

Haowei Wu via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 19 16:15:29 PDT 2023


haowei added a comment.

In D155760#4516664 <https://reviews.llvm.org/D155760#4516664>, @ldionne wrote:

> I reverted this change. As a matter of policy, please do not commit patches to libc++ unless the libc++ review group is green. The review process we follow is documented here: https://libcxx.llvm.org/Contributing.html#the-review-process -- it is a bit stricter than the usual LLVM review process because we have an automatically-added review group.
>
> Furthermore, the change itself looked wrong, see my comment.

OK, I will pay attention next time.

If `libcxx-abi-version-1` is not a defined feature, could you explain why it works?

If


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155760/new/

https://reviews.llvm.org/D155760



More information about the libcxx-commits mailing list