[libcxx-commits] [PATCH] D155760: [libcxx] Fix "copy_move.pass" test

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I reverted this change. As a matter of policy, please do not commit patches to libc++ unless the libc++ review group is green. The review process we follow is documented here: https://libcxx.llvm.org/Contributing.html#the-review-process -- it is a bit stricter than the usual LLVM review process because we have an automatically-added review group.

Furthermore, the change itself looked wrong, see my comment.



================
Comment at: libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/copy_move.pass.cpp:11
 // allocations.
-// XFAIL: target=x86_64-pc-windows-msvc && stdlib=libc++
+// XFAIL: target=x86_64-pc-windows-msvc && stdlib=libc++ && libcxx-abi-version-1
 
----------------
`libcxx-abi-version-1` is not a Lit feature that we ever populate. We do have `libcpp-abi-version=<VERSION>`, so this should probably be `libcpp-abi-version=1`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155760/new/

https://reviews.llvm.org/D155760