[libcxx-commits] [PATCH] D155364: [libc++][format] Improves compile-time diagnostics.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ nitpicks.



================
Comment at: libcxx/include/__format/parser_std_format_spec.h:316
+  // - Only parses a field when it is in the __fields. Accepting all
+  //   fields and then validate the valid ones has a performance impact.
+  //   This is faster but gives slighly worse error messages.
----------------



================
Comment at: libcxx/include/__format/parser_std_format_spec.h:318
+  //   This is faster but gives slighly worse error messages.
+  // - compile-time when a field is not accepted the parser will still
+  //   parse it and give an error when it's present. This gives a more
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155364/new/

https://reviews.llvm.org/D155364