[libcxx-commits] [PATCH] D155364: [libc++][format] Improves compile-time diagnostics.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 15 12:02:08 PDT 2023


Mordante added a subscriber: ldionne.
Mordante added inline comments.


================
Comment at: libcxx/include/__format/parser_std_format_spec.h:344
+        return __begin;
+    } else if (std::is_constant_evaluated() && __parse_alternate_form(__begin))
+      std::__throw_format_error("The format specifier does not allow the alternate form option");
----------------
Use braces here.

@ldionne this will be done before landing, just not something I wanted to do when splitting the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155364/new/

https://reviews.llvm.org/D155364



More information about the libcxx-commits mailing list