[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision as: philnik.
philnik added a comment.

LGTM. Leaving final approval to @ldionne, since he knows the CI best.



================
Comment at: libcxx/test/std/atomics/atomics.types.generic/integral.pass.cpp:9
 
+// XFAIL: !atomics
+
----------------
I would just go with `// REQUIRES: atomics`. That's a lot less confusing that the double negation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246