[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Michael Platings via Phabricator via libcxx-commits]

michaelplatings added inline comments.


================
Comment at: libcxx/test/std/atomics/atomics.types.generic/integral.pass.cpp:9
 
+// "undefined symbol: __atomic_load_8"
+// XFAIL: LIBCXX-PICOLIBC-FIXME
----------------
Mordante wrote:
> michaelplatings wrote:
> > philnik wrote:
> > > I guess this is caused by a missing libatomic?
> > Yes, there's no libatomic or equivalent. Perhaps something like `REQUIRES: atomic` would be better here.
> When there are no plans to add that to picolib soon I think we indeed should add something like `//UNSUPPRTED: no-libatomic` (maybe needs a better name). The `LIBCXX-PICOLIBC-FIXME` should be used for things that can be fixed.
For consistency with the existing `non-lockfree-atomics` feature I've gone with the name `atomics`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246