[libcxx-commits] [PATCH] D151493: [libcxx] Handle windows system error code mapping in std::error_code.

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo accepted this revision.
mstorsjo added a comment.

Overall, this LGTM, but I'm not a libcxx approver.



================
Comment at: libcxx/test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.derived/message.pass.cpp:37
+#endif
+    assert(m2 != m3);
 
----------------
This changes what is tested for other platforms, previously this checked `m1 != m3`, now it checks `m2 != m3`. Although it is tested above that `m1 == m2` though... (A comment about this change could be good, it's not immediately obvious to me what is fixed here.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151493/new/

https://reviews.llvm.org/D151493