[libcxx-commits] [PATCH] D148693: [libc++] Set correct size at the end of growing std::string

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM with a suggestion to rephrase a comment.



================
Comment at: libcxx/include/string:2283-2285
+// __grow_by is deprecated because it does not set size. It not only may not update when size is changed,
+// but also not set size at all when string was short initially, leading to unpredictable size value.
+// It is not removed or changed to avoid breaking the ABI.
----------------
Just rewording, IMO this is easier to read. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148693/new/

https://reviews.llvm.org/D148693