[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I want to have a closer look when the CI is green. But it seems the number of disabled tests is quite small :-)



================
Comment at: libcxx/test/std/atomics/atomics.types.generic/integral.pass.cpp:9
 
+// "undefined symbol: __atomic_load_8"
+// XFAIL: LIBCXX-PICOLIBC-FIXME
----------------
michaelplatings wrote:
> philnik wrote:
> > I guess this is caused by a missing libatomic?
> Yes, there's no libatomic or equivalent. Perhaps something like `REQUIRES: atomic` would be better here.
When there are no plans to add that to picolib soon I think we indeed should add something like `//UNSUPPRTED: no-libatomic` (maybe needs a better name). The `LIBCXX-PICOLIBC-FIXME` should be used for things that can be fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246