[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Michael Platings via Phabricator via libcxx-commits]

michaelplatings marked 5 inline comments as done.
michaelplatings added inline comments.


================
Comment at: libcxx/utils/libcxx/test/features.py:207
+              int fd[2];
+              return pipe(fd);
             }
----------------
michaelplatings wrote:
> arichardson wrote:
> > Why pipe? Is that function actually called inside libc++?
> `check_assertion.h` uses pipe, fork, exec etc. Picolibc declares these in `unistd.h` but doesn't implement them. Therefore this feature check was previously passing with picolibc, but now fails at link time.
(Despite the name "has-unix-headers", the check is mostly (always?) used to xfail tests that use `check_assertion.h`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246