[libcxx-commits] [PATCH] D155258: [libc++] Granulaize math.h and move the functions to std::__math

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp:10
+// Clang complains that fabs is called with an integer
+// ADDITIONAL_COMPILE_FLAGS: -Wno-absolute-value
+
----------------
philnik wrote:
> Mordante wrote:
> > Why is this needed, can you mention this in the commit message?
> I'll check again whether it's actually needed. This might just be a leftover from trying to fix something. (I suspect it's not actually needed)
It would be great when it's not needed. This feels a bit out of place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155258/new/

https://reviews.llvm.org/D155258