[libcxx-commits] [PATCH] D155258: [libc++] Granulaize math.h and move the functions to std::__math

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

mostly LGTM, but some minor issue.



================
Comment at: libcxx/include/__math/remainder.h:10
+#ifndef _LIBCPP___MATH_REMAINDER_H
+#define _LIBCPP___MATH_REMAINDER_H
+
----------------
Nit: since the file contains modulo to, how about naming the file `math_division.h` instead or move the modulo to its own file.


================
Comment at: libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp:10
+// Clang complains that fabs is called with an integer
+// ADDITIONAL_COMPILE_FLAGS: -Wno-absolute-value
+
----------------
Why is this needed, can you mention this in the commit message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155258/new/

https://reviews.llvm.org/D155258