[libcxx-commits] [PATCH] D155116: [libc++][Modules] Remove spurious std.string export from std.format.__format.format_functions
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jul 14 08:53:44 PDT 2023
Mordante added a comment.
I think the change is the wrong direction. `std::format` returns a `std::string`. In my experience arguments and return values often need to be explicitly exported. So I think the proper fix would be to include `string` in this header. The main issue is that accidentally forgotten headers worked in the past.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155116/new/
https://reviews.llvm.org/D155116
More information about the libcxx-commits
mailing list