[libcxx-commits] [PATCH] D155116: [libc++][Modules] Remove spurious std.string export from std.format.__format.format_functions

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 12 13:55:07 PDT 2023


iana created this revision.
iana added reviewers: ldionne, Mordante.
Herald added a subscriber: ributzka.
Herald added a project: All.
iana requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

<__format/format_functions.h> no longer includes <string>, so its module shouldn't try to export it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155116

Files:
  libcxx/include/module.modulemap.in


Index: libcxx/include/module.modulemap.in
===================================================================
--- libcxx/include/module.modulemap.in
+++ libcxx/include/module.modulemap.in
@@ -992,10 +992,7 @@
         export locale
       }
       module format_error                    { private header "__format/format_error.h" }
-      module format_functions                {
-        private header "__format/format_functions.h"
-        export string
-      }
+      module format_functions                { private header "__format/format_functions.h" }
       module format_fwd                      { private header "__format/format_fwd.h" }
       module format_parse_context            { private header "__format/format_parse_context.h" }
       module format_string                   { private header "__format/format_string.h" }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155116.539718.patch
Type: text/x-patch
Size: 841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230712/a532a602/attachment.bin>


More information about the libcxx-commits mailing list