[libcxx-commits] [PATCH] D134420: [libc++] Use intptr_t instead of ptrdiff_t for messages_base::catalog

Mon Jul 10 09:38:45 PDT 2023

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This seems like a good change to me. I had ABI impact concerns but I read and re-read your commit + the discussion in the thread, and I am fine with this.

LGTM but we need to add a few tests, rebase this and get a green CI run.

================
Comment at: libcxx/include/locale:3456
 #ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
 extern template class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS money_put<wchar_t>;
 #endif
----------------
Can we add a libc++ specific test that asserts `is_same<messages_base::catalog, intptr_t>`?

Also a non-libc++-specific test to check for the implementation of `LWG2028`? It could assert that `is_signed<messages_base::catalog>`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134420/new/

https://reviews.llvm.org/D134420