[libcxx-commits] [PATCH] D134420: [libc++] Use intptr_t instead of ptrdiff_t for messages_base::catalog

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 10 09:15:41 PDT 2023


ldionne added a comment.

In D134420#4485499 <https://reviews.llvm.org/D134420#4485499>, @arichardson wrote:

> Is there any chance someone else who has the ability to approve this for #libc <https://reviews.llvm.org/tag/libc/> could do so since it appears @ldionne is not interested in this change. I get that this currently does not break any production targets, but IMO it does clean up the code for glibc and macOS as well.

I'm not disinterested, I just didn't see it amongst the ton of changes that I get pinged on. Let me take a look now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134420/new/

https://reviews.llvm.org/D134420



More information about the libcxx-commits mailing list