[libcxx-commits] [PATCH] D154590: [libc++] mark barrier constructor as constexpr explicit in <barrier>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/barrier:297
         return __barrier_base<_CompletionF>::max();
     }
----------------
diamante0018 wrote:
> Mordante wrote:
> > Can you upload the new diff with context?
> I should be able to address your review and upload the new additions here, yes. I hope that is what you mean. Thanks for your review
No with context means either using the arc tool or a `diff -U999999`. If you look at other patches, for example https://reviews.llvm.org/D153037 you can show all existing lines in the patch. That is useful for reviewers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154590/new/

https://reviews.llvm.org/D154590