[libcxx-commits] [PATCH] D154590: [libc++] mark barrier constructor as constexpr explicit in <barrier>

[Edo via Phabricator via libcxx-commits]

diamante0018 added a comment.

In D154590#4477808 <https://reviews.llvm.org/D154590#4477808>, @philnik wrote:

> There is no need to add `inline` everywhere. In these cases it most likely doesn't actually do anything. Please add tests that the constructor is `constexpr` and `explicit`. You can test the `constexpr` by adding a gloabl `constinit` variable and the `explicit` by making sure that `is_convertible_v<...>` is false.

Understood, I will do that in an hour or so. Thanks for your review as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154590/new/

https://reviews.llvm.org/D154590